Skip to content

Make FileFormat case insensitive #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2020
Merged

Conversation

Dandandan
Copy link
Contributor

@coveralls
Copy link

coveralls commented Jun 12, 2020

Pull Request Test Coverage Report for Build 133462510

  • 6 of 8 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 91.766%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser.rs 3 5 60.0%
Totals Coverage Status
Change from base Build 132720988: 0.06%
Covered Lines: 4079
Relevant Lines: 4445

💛 - Coveralls

@nickolay
Copy link
Contributor

I think we shouldn't use parse_identifier for keywords (like in https://github.com/andygrove/sqlparser-rs/pull/193#discussion_r438399675 ). If the idea is to support STORED AS "TEXTFILE", we should store it as an identifier in the AST. Otherwise, why not add the keywords to the global list?

@Dandandan
Copy link
Contributor Author

I agree it makes sense to also parse it as an keyword and fix it in a more "general' way

@nickolay nickolay merged commit 68afa2a into apache:master Jun 12, 2020
@nickolay
Copy link
Contributor

OK, I've merged this PR to fix the bug, leaving the general way as a possible future improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants